Increase range of job_sync_duration_seconds #120577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
k8s-ci-robot
added
sig/apps
|
/assign @logicalhan |
logicalhan
reviewed
Sep 11, 2023
Change-Id: I7ed4b006faecf0a7e6e583c42b4d6bc4b786a164
alculquicondor
force-pushed
the
job_latency_res
branch
from
dd05b34
to
6b4ab61
Compare
|
Oops, fixed |
k8s-ci-robot
added
area/stable-metrics
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 3928685df2cf8f31073f5ef5afbdfddc1e36de9f
|
k8s-ci-robot
added
the
approved
This was referenced Sep 14, 2023
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 21, 2023
…77-upstream-release-1.28 Automated cherry pick of #120577: Increase range of job_sync_duration_seconds
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 21, 2023
…77-upstream-release-1.25 Automated cherry pick of #120577: Increase range of job_sync_duration_seconds
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 21, 2023
…77-upstream-release-1.26 Automated cherry pick of #120577: Increase range of job_sync_duration_seconds
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 21, 2023
…77-upstream-release-1.27 Automated cherry pick of #120577: Increase range of job_sync_duration_seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Set the lower end to 4ms, which makes the higher bucket reach 1min.
The job controller makes up to 2 operations per pod in a sync, and it can process up to 500 pods. Having visibility up to 1 min can give a better sense of the performance of the controller when using a low API QPS, such as 20, the default.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: