New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #120623: sync Service API status rest storage #120656
Automated cherry pick of #120623: sync Service API status rest storage #120656
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig network |
The Service API Rest implementation is complex and has to use different hooks on the REST storage. The status store was making a shallow copy of the storage before adding the hooks, so it was not inheriting the hooks. The status store must have the same hooks as the rest store to be able to handle correctly the allocation and deallocation of ClusterIPs and nodePorts. Change-Id: I44be21468d36017f0ec41a8f912b8490f8f13f55 Signed-off-by: Antonio Ojea <aojea@google.com>
c2d653d
to
9a992ba
Compare
/lgtm |
LGTM label has been added. Git tree hash: e95a9d47a77136a04773e27ce9eea24a3f83744b
|
ping @kubernetes/release-managers |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, liggitt, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry pick of #120623 on release-1.26.
#120623: sync Service API status rest storage
For details on the cherry pick process, see the cherry pick requests page.