Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttachDetachControllerConfiguration.ReconcilerSyncLoopPeriod default value comment fix #120666

Merged
merged 1 commit into from
Oct 11, 2023
Merged

AttachDetachControllerConfiguration.ReconcilerSyncLoopPeriod default value comment fix #120666

merged 1 commit into from
Oct 11, 2023

Conversation

b8kings0ga
Copy link
Contributor

What type of PR is this?

this is the alternative PR for #118708 because I change my computer and accidentally closed that one

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #118700

Special notes for your reviewer:
default is located at:
/pkg/controller/volume/attachdetach/config/v1alpha1/defaults.go

// RecommendedDefaultAttachDetachControllerConfiguration defaults a pointer to a // AttachDetachControllerConfiguration struct. This will set the recommended default // values, but they may be subject to change between API versions. This function // is intentionally not registered in the scheme as a "normal"SetDefaults_Foo// function to allow consumers of this type to set whatever defaults for their // embedded configs. Forcing consumers to use these defaults would be problematic // as defaulting in the scheme is done as part of the conversion, and there would // be no easy way to opt-out. Instead, if you want to use this defaulting method // run it in your wrapper struct of this type in itsSetDefaults_` method.
func RecommendedDefaultAttachDetachControllerConfiguration(obj *kubectrlmgrconfigv1alpha1.AttachDetachControllerConfiguration) {
zero := metav1.Duration{}
if obj.ReconcilerSyncLoopPeriod == zero {
obj.ReconcilerSyncLoopPeriod = metav1.Duration{Duration: 60 * time.Second}
}
}

`

Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @b8kings0ga. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 14, 2023
@b8kings0ga
Copy link
Contributor Author

@carlory Sorry I accidentally closed the last PR since I reset to last commit instead of "My" last commit, and I recommit it and running make update. please review if anything else is wrong

@carlory
Copy link
Member

carlory commented Sep 14, 2023

/ok-to-test
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2023
@b8kings0ga
Copy link
Contributor Author

b8kings0ga commented Sep 14, 2023 via email

@b8kings0ga
Copy link
Contributor Author

b8kings0ga commented Sep 14, 2023 via email

@b8kings0ga
Copy link
Contributor Author

b8kings0ga commented Sep 14, 2023 via email

@b8kings0ga
Copy link
Contributor Author

b8kings0ga commented Sep 14, 2023 via email

@leilajal
Copy link
Contributor

/remove-sig api-machinery

@liggitt
Copy link
Member

liggitt commented Sep 21, 2023

@b8kings0ga make sure you have fetched latest tags before you regenerate openapi, it looks like your local git repo thinks it is on an older k8s version

@jiahuif
Copy link
Member

jiahuif commented Sep 21, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 21, 2023
@carlory
Copy link
Member

carlory commented Sep 22, 2023

@b8kings0ga please use fetch and rebase commands to fetch and merge upstream changes into your local branch.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Sep 22, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 22, 2023
@b8kings0ga
Copy link
Contributor Author

b8kings0ga commented Sep 22, 2023 via email

@b8kings0ga
Copy link
Contributor Author

@liggitt you are right, after running

git remote update

all latest tag are fetched and things go right, thanks!

@b8kings0ga
Copy link
Contributor Author

@carlory sorry for that, I'm aware now

@carlory
Copy link
Member

carlory commented Sep 23, 2023

/lgtm

/assign @msau42 @thockin

for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 433bbd4da0d9a49ce6f6de3591ef646ef538d875

@b8kings0ga
Copy link
Contributor Author

@msau42 @thockin thanks for the approval

@alexzielenski
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 26, 2023
@b8kings0ga
Copy link
Contributor Author

@msau42 sorry but can you "/approve" this again because I accidentally close the last PR and didn't thought I have permission to reopen it 😅

@thockin
Copy link
Member

thockin commented Oct 11, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: b8kings0ga, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0702999 into kubernetes:master Oct 11, 2023
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@mauriciopoppe mauriciopoppe Awaiting requested review from mauriciopoppe

Assignees

@thockin thockin

@msau42 msau42

@carlory carlory

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

AttachDetachControllerConfiguration.ReconcilerSyncLoopPeriod Comment error
9 participants
@b8kings0ga @k8s-ci-robot @carlory @leilajal @alexzielenski @liggitt @jiahuif @thockin @msau42