-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a wider-range of metric buckets for PodStartDuration #120680
Conversation
Signed-off-by: ruiwen-zhao <ruiwen@google.com>
/sig instrumentation |
/retest |
/triage accepted We should ideally use exponential buckets instead of manually setting boundaries: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/metrics/buckets.go#L32 |
/priority important-longterm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrunalp, ruiwen-zhao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: dd1fde866090d8d441c714a5a7215fb2697f1226
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Current max bucket for PodStartDuration is 10 seconds, which is not enough for the metric PodStartDuration, which spans from pod scheduling to pod starting. (Note that image pulling time is included in PodStartDuration).
This PR changes the bucket to the same as PodStartSLIDuration.
Similar effort has been done on RuntimeOperationsDuration metric in #96054
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: