Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #120814: Fix 120758 - prevent cache Load on uninitialized spec #121040

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Automated cherry pick of #120814: Fix 120758 - prevent cache Load on uninitialized spec #121040

merged 4 commits into from
Oct 12, 2023

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Oct 6, 2023 •
edited by liggitt

Cherry pick of #120814 on release-1.28.

#120814: Fix 120758 - prevent cache Load on uninitialized spec

For details on the cherry pick process, see the cherry pick requests page.

Fix 1.28.0 regression where adding aggregated APIService objects could cause apiserver to panic and affect the health check

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 6, 2023
@k8s-ci-robot k8s-ci-robot added area/test do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 6, 2023
@Jefftree
Copy link
Member Author

Jefftree commented Oct 6, 2023

/cc @apelisse
/triage accepted

Had to rename a couple of things because of the interface changes from #119526 in 1.29. Probably good to wait until the CI is all green before lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 6, 2023
@liggitt
Copy link
Member

liggitt commented Oct 9, 2023 •
edited

are we confident this without #119526 is still correct? (I'm happy minimizing the size of the backport, just wanting us to think carefully about whether there's any intersecting fixes made in #119526 this is missing)

@liggitt
Copy link
Member

liggitt commented Oct 9, 2023

/retest

@apelisse
Copy link
Member

apelisse commented Oct 9, 2023 •
edited

@sttts IIRC, #119526 is about renaming things.

@liggitt
Copy link
Member

liggitt commented Oct 9, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c2cadbb7a45df1e6b07911153516671823ecbfb0

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@liggitt
Copy link
Member

liggitt commented Oct 11, 2023

/kind regression
/kind bug
/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team October 11, 2023 12:47
@k8s-ci-robot k8s-ci-robot added kind/regression Categorizes issue or PR as related to a regression from a prior release. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 11, 2023
@saschagrunert saschagrunert added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, liggitt, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented Oct 12, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit e3b5e62 into kubernetes:release-1.28 Oct 12, 2023
15 checks passed
@liggitt liggitt added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@liggitt liggitt Awaiting requested review from liggitt

@SataQiu SataQiu Awaiting requested review from SataQiu

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jefftree @liggitt @apelisse @k8s-ci-robot @pacoxu @saschagrunert