Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrent map writes on missing PVC creation in StatefulSet controller #121142

Merged
merged 2 commits into from Oct 12, 2023
Merged

Fix concurrent map writes on missing PVC creation in StatefulSet controller #121142

merged 2 commits into from Oct 12, 2023

Conversation

aleksandra-malinowska
Copy link
Contributor

@aleksandra-malinowska aleksandra-malinowska commented Oct 11, 2023 •
edited by liggitt

What type of PR is this?

/kind bug

What this PR does / why we need it:

Eliminates concurrent map writes detected in #121053.

Which issue(s) this PR fixes:

Fixes #121053

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed a 1.28.0 regression where kube-controller-manager can crash when StatefulSet with Parallel policy and PVC labels is scaled up.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 11, 2023
This was referenced Oct 11, 2023
Closed
Closed
@aleksandra-malinowska
Copy link
Contributor Author

cc @liggitt @soltysh

@liggitt
Copy link
Member

liggitt commented Oct 11, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c32b2e97d2e65693a78ec33cceeeb26a86416066

@liggitt liggitt added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Oct 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleksandra-malinowska, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@liggitt
Copy link
Member

liggitt commented Oct 11, 2023

thanks, please cherry-pick to the regressed branches and include the specific patch version for the minor that regressed in each cherry-pick PR's release note (e.g. "Fixes a regression in 1.27.3 where ....")

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@aleksandra-malinowska
Copy link
Contributor Author

Modified to add PVC labels only to this test.

@aleksandra-malinowska
Copy link
Contributor Author

aleksandra-malinowska commented Oct 12, 2023 •
edited

@liggitt @soltysh this lost lgtm and approve as I had to adjust the change to unit tests. Can you PTAL?

@liggitt
Copy link
Member

liggitt commented Oct 12, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 78e78d62a8cb6ac03f27668278a8d4f7b32a004f

@k8s-ci-robot k8s-ci-robot merged commit bae6911 into kubernetes:master Oct 12, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 12, 2023
This was referenced Oct 12, 2023
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Oct 16, 2023
@k8s-ci-robot
Merge pull request #121186 from aleksandra-malinowska/automated-cherr…
b7dce62 
…y-pick-of-#121142-upstream-release-1.26

Automated cherry pick of #121142: Modify test PVC to detect concurrent map write bug
k8s-ci-robot added a commit that referenced this pull request Oct 16, 2023
@k8s-ci-robot
Merge pull request #121184 from aleksandra-malinowska/automated-cherr…
64799e0 
…y-pick-of-#121142-upstream-release-1.28

Automated cherry pick of #121142: Modify test PVC to detect concurrent map write bug
k8s-ci-robot added a commit that referenced this pull request Oct 16, 2023
@k8s-ci-robot
Merge pull request #121187 from aleksandra-malinowska/automated-cherr…
4c71fe8 
…y-pick-of-#121142-upstream-release-1.25

Automated cherry pick of #121142: Modify test PVC to detect concurrent map write bug
k8s-ci-robot added a commit that referenced this pull request Oct 16, 2023
@k8s-ci-robot
Merge pull request #121185 from aleksandra-malinowska/automated-cherr…
16bd7dd 
…y-pick-of-#121142-upstream-release-1.27

Automated cherry pick of #121142: Modify test PVC to detect concurrent map write bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree Awaiting requested review from atiratree

@krmayankk krmayankk Awaiting requested review from krmayankk

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

kube-controller-manager crashed with fatal error: concurrent map writes
3 participants
@aleksandra-malinowska @k8s-ci-robot @liggitt