Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

framework: add SSH support for Azure #121708

Merged
merged 1 commit into from Nov 4, 2023
Merged

framework: add SSH support for Azure #121708

merged 1 commit into from Nov 4, 2023

Conversation

aravindhp
Copy link
Contributor

@aravindhp aravindhp commented Nov 2, 2023 •
edited

What this PR does / why we need it:

Add Azure to the list of providers that support accessing nodes using SSH. This will allow running NodeLogQuery e2e tests introduced in #121707

Special notes for your reviewer:

This will require a follow up PR adding the required environment variables, AZURE_SSH_KEY, KUBE_SSH_BASTION to the test configuration. Ref: kubernetes-sigs/windows-testing#412

@aravindhp
framework: add SSH support for Azure
34b2c4e 
Add Azure to the list of providers that support accessing nodes
using SSH.
Note: This will require a follow up PR adding the required
environment variables, AZURE_SSH_KEY, KUBE_SSH_BASTION to the test
configuration.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 2, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 2, 2023
@k8s-ci-robot k8s-ci-robot added area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 2, 2023
@aravindhp
Copy link
Contributor Author

/cc @marosset @jsturtevant

@aravindhp aravindhp mentioned this pull request Nov 2, 2023
Merged
@jsturtevant
Copy link
Contributor

/lgtm
/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d732b5f36d459ac2842701e04fc799f0d6b096cf

@jsturtevant
Copy link
Contributor

/kind cleanup
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 3, 2023
@marosset
Copy link
Contributor

marosset commented Nov 3, 2023

/lgtm

pohly
pohly approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I don't like that framework/ssh needs to know about providers. That should be hidden behind the provider interface - but I guess that's a bigger change that'll have to wait.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, pohly, r0b2g1t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@pacoxu
Copy link
Member

pacoxu commented Nov 4, 2023

/milestone v1.29
as this is for test

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 4, 2023
@aravindhp
Copy link
Contributor Author

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit 24e6b03 into kubernetes:master Nov 4, 2023
15 checks passed
bzsuni pushed a commit to bzsuni/kubernetes that referenced this pull request Nov 6, 2023
@k8s-ci-robot @bzsuni
Merge pull request kubernetes#121708 from aravindhp/add-azure-framewo…
1db1a3a 
…rk-ssh-provider

framework: add SSH support for Azure
Signed-off-by: bzsuni <bingzhe.sun@daocloud.io>
@lzhecheng lzhecheng mentioned this pull request Nov 15, 2023
Open
@aravindhp aravindhp mentioned this pull request Nov 17, 2023
Merged
@aravindhp aravindhp deleted the add-azure-framework-ssh-provider branch January 4, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@r0b2g1t r0b2g1t r0b2g1t approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

@marosset marosset Awaiting requested review from marosset

Assignees

@jsturtevant jsturtevant

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@aravindhp @k8s-ci-robot @jsturtevant @marosset @pacoxu @pohly @r0b2g1t