-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix service account token projected volume validation #121731
Fix service account token projected volume validation #121731
Conversation
Welcome @Taction! |
Hi @Taction. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig auth |
/lgtm |
/test pull-kubernetes-e2e-kind |
/retest |
Hello, I'm new here. It would take me some more time to figure out why e2e tests failed. Besides, who can help point out how to run k8s e2e tests locally or how to inspect what is wrong in the tests, any help would be appreciated. |
/lgtm cancel fix the nil check and squash down the change to a single commit, thanks |
/triage accepted |
Signed-off-by: zhangchao <zchao9100@gmail.com>
988d5fb
to
7972f03
Compare
@liggitt Thank you so much for the advice, it works! |
/lgtm |
LGTM label has been added. Git tree hash: a4ce8d6995ed4d6b7726b9336a15dee430f0f771
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, Taction The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Add one of the following kinds:
/kind bug
What this PR does / why we need it:
Service account token projected volume validation should call validateLocalNonReservedPath on the token path.
Which issue(s) this PR fixes:
Fixes #121415
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: