fix test store delete collection function failed #121780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
/assign @wojtek-t |
wojtek-t
reviewed
Nov 7, 2023
| @@ -2042,6 +2042,9 @@ func TestStoreDeleteCollection(t *testing.T) { | |||
| storeWithCounter := &storageWithCounter{Interface: registry.Storage.Storage} | |||
| registry.Storage.Storage = storeWithCounter | |||
| deleteCollectionPageSize = 2 | |||
| defer func() { | |||
| deleteCollectionPageSize = int64(10000) | |||
| }() | |||
There was a problem hiding this comment.
Great finding. Instead of setting 10000 value here, can you please restore to the value to which it was set before?
So sth like:
originalDeleteCollectionPageSize = deleteCollectionPageSize
deleteCollectionPageSize = 2
defer func() {
deleteCollectionPageSize = originalDeleteCollectionPageSize
}()
|
/priority important-longterm |
k8s-ci-robot
added
priority/important-longterm
HirazawaUi
force-pushed
the
fix-delete-collection-test-failed
branch
from
870f830
to
b12db6d
Compare
|
/lgtm /milestone v1.29 |
|
/retest |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 63a4664f482992dfa4c9a83033866d444ea85a72
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HirazawaUi, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Once we make the GetList in DeleteCollection respect the timeout context, here's what makes the other test functions fail
Which issue(s) this PR fixes:
Fixes #121627
Special notes for your reviewer:
deleteCollectionPageSize = 2will overwrite the value of the global variable deleteCollectionPageSize, causing other tests to fail, so after we execute this test function, we reset it to its default valueint64(10000)Does this PR introduce a user-facing change?