Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test authz config file with RBAC and anonymous auth #121818

Merged
merged 4 commits into from Nov 8, 2023

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 8, 2023

What type of PR is this?

/kind bug
/kind test

What this PR does / why we need it:

  • Adds a test for authz config working with anonymous auth and default RBAC policies
  • Adds ability to test authz config with local-up-cluster
  • Fixes a bug inspecting --authorization-mode flag value for anonymous auth when using --authorization-config
  • Fixes a bug inspecting --authorization-mode flag value for default RBAC policy when using --authorization-config
NONE

/assign @enj @palnabarun @ritazh
/milestone v1.29

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 8, 2023
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2023
@k8s-ci-robot
Copy link
Contributor

@liggitt: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind bug
/kind test

What this PR does / why we need it:

  • Adds a test for authz config working with anonymous auth and default RBAC policies
  • Adds ability to test authz config with local-up-cluster
  • Fixes a bug inspecting --authorization-mode flag value for anonymous auth when using --authorization-config
  • Fixes a bug inspecting --authorization-mode flag value for default RBAC policy when using --authorization-config
NONE

/assign @enj @palnabarun @ritazh
/milestone v1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023
@liggitt
Copy link
Member Author

liggitt commented Nov 8, 2023

updated comment and fixed linter complaint

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 8, 2023

@liggitt: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-local-e2e 819d190 link false /test pull-kubernetes-local-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member Author

liggitt commented Nov 8, 2023

(local-e2e was already failing, see job history)

@ritazh
Copy link
Member

ritazh commented Nov 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 93e7c50bc2d823f53d662990cb84bee880fc56b2

@k8s-ci-robot k8s-ci-robot merged commit d26c154 into kubernetes:master Nov 8, 2023
15 of 16 checks passed
@alexzielenski
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

6 participants