Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update publishing-bot rules for active release branches that uses go120 to Go 1.20.11 #121870

Merged
merged 1 commit into from Nov 14, 2023
Merged

Update publishing-bot rules for active release branches that uses go120 to Go 1.20.11 #121870

merged 1 commit into from Nov 14, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 14, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Update publishing-bot rules for active release branches that uses go1.20 to Go 1.20.11

Which issue(s) this PR fixes:

xref: kubernetes/release#3347

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @saschagrunert @jeremyrickard @liggitt @nikhita
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 14, 2023
@cpanato cpanato mentioned this pull request Nov 14, 2023
Closed
27 tasks
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 14, 2023
@cpanato
Copy link
Member Author

cpanato commented Nov 14, 2023

/assign @saschagrunert @jeremyrickard @liggitt @nikhita

xmudrii
xmudrii approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f1aeb4a9022dd9e8a0d697c1a0107e9dadc032e

@cpanato
Copy link
Member Author

cpanato commented Nov 14, 2023

/milestone v1.29

@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 14, 2023
@xmudrii
Copy link
Member

xmudrii commented Nov 14, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2023
@cpanato cpanato changed the title Update publishing-bot rules for active release branches that uses go120 to Go 1.20.11 and drop release-1.25 config Update publishing-bot rules for active release branches that uses go120 to Go 1.20.11 Nov 14, 2023
xmudrii
xmudrii approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 316c2b9a5438f544d12a2a2597e8c8c98567ab35

@xmudrii
Copy link
Member

xmudrii commented Nov 14, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2023
@cpanato cpanato requested a review from xmudrii November 14, 2023 17:51
@cpanato
Update publishing-bot rules for active release branches that uses go1…
8c68aa6 
…20 to Go 1.20.11

Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@dims
Copy link
Member

dims commented Nov 14, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9e1ef3a0ec21aa5b3676f1f38e42668860ad8847

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1bb2773 into kubernetes:master Nov 14, 2023
15 checks passed
@cpanato cpanato deleted the rulesup branch November 14, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@justaugustus justaugustus Awaiting requested review from justaugustus

@liggitt liggitt Awaiting requested review from liggitt

@nikhita nikhita Awaiting requested review from nikhita

@saschagrunert saschagrunert Awaiting requested review from saschagrunert

Assignees

@dims dims

@saschagrunert saschagrunert

@liggitt liggitt

@nikhita nikhita

@xmudrii xmudrii

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cpanato @k8s-ci-robot @xmudrii @dims @saschagrunert @liggitt @nikhita @jeremyrickard