Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sched framework: expose NodeInfo in all functions of PluginsRunner interface #121954

Merged
merged 1 commit into from Dec 15, 2023
Merged

Sched framework: expose NodeInfo in all functions of PluginsRunner interface #121954

merged 1 commit into from Dec 15, 2023

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented Nov 19, 2023

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Use NodeInfo instead of Node like other functions.

  • consistent function signature - all use NodeInfo

  • unleash more potential to use scheduler framework natively w/o hacks

Which issue(s) this PR fixes:

Fixes #119987

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Update some interfaces' signature in scheduler:

1. PluginsRunner: use NodeInfo in `RunPreScorePlugins` and `RunScorePlugins`.
2. PreScorePlugin: use NodeInfo in `PreScore`.
3. Extender: use NodeInfo in `Filter` and `Prioritize`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 19, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 19, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Nov 24, 2023
@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Archive-it in SIG Node CI/Test Board Nov 29, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Dec 8, 2023

/sig autoscaling
/cc @alculquicondor

@k8s-ci-robot k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Dec 8, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Dec 8, 2023
alculquicondor
alculquicondor reviewed Dec 8, 2023
View reviewed changes
pkg/scheduler/extender.go Show resolved Hide resolved
pkg/scheduler/framework/plugins/dynamicresources/dynamicresources.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/types.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/types.go Outdated Show resolved Hide resolved
@AxeZhan
Copy link
Member Author

AxeZhan commented Dec 13, 2023

squashed
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2023
alculquicondor
alculquicondor reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@pacoxu
Copy link
Member

pacoxu commented Dec 14, 2023 •
edited

/hold
see some failure in batch job run.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/batch/pull-kubernetes-integration/1735128097969147904

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2023
@pacoxu
Copy link
Member

pacoxu commented Dec 14, 2023

/retest

@AxeZhan
Copy link
Member Author

AxeZhan commented Dec 14, 2023

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/batch/pull-kubernetes-integration/1735128097969147904

I see, we implement Prescore extension for some plugins in this release. As those prs got merged first, this pr needs a rebase.

#115768 for an example.

I'll do a rebase later.

@pacoxu
Copy link
Member

pacoxu commented Dec 14, 2023

/lgtm cancel

I'll do a rebase later.

👍 Thanks for the quick confirmation.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 14, 2023
@AxeZhan
Copy link
Member Author

AxeZhan commented Dec 14, 2023

I see, we implement Prescore extension for some plugins in this release. As those prs got merged first, this pr needs a rebase.

This is a simple conflict fix(see second commit).
/cc @chendave @denkensk Do you have time for a quick lgtm?
I'll rebase and cancel hold after one reviewer gives lgtm.

@AxeZhan
Copy link
Member Author

AxeZhan commented Dec 15, 2023

rebased again
/cc @alculquicondor @Huang-Wei

alculquicondor
alculquicondor reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f939287745a3e8d99cb2e78bea97f8f74d72673a

@alculquicondor
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit e04316a into kubernetes:master Dec 15, 2023
18 checks passed
SIG Node CI/Test Board automation moved this from Archive-it to Done Dec 15, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Dec 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@chendave chendave Awaiting requested review from chendave

@denkensk denkensk Awaiting requested review from denkensk

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@alculquicondor alculquicondor

@pacoxu pacoxu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node CI/Test Board
Done
SIG Node PR Triage
Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

sched framework: expose NodeInfo in all functions of PluginsRunner interface
5 participants
@AxeZhan @k8s-ci-robot @bart0sh @alculquicondor @pacoxu