New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for Job Controller for panic when PodFailurePolicy is used on 1.28 #122261
Add unit test for Job Controller for panic when PodFailurePolicy is used on 1.28 #122261
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Dec 11 04:18:32 UTC 2023. |
/assign @kannon92 |
/triage accepted /lgtm |
LGTM label has been added. Git tree hash: 3319d034e2f5355537e416c7bb8250e62e3d77a8
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If necessary we can just backport afterwards |
…61-upstream-release-1.28 Automated cherry pick of #122261: Add unit test for Job Controller for panic when PodFailurePolicy is used
…61-upstream-release-1.29 Automated cherry pick of #122261: Add unit test for Job Controller for panic when PodFailurePolicy is used
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #122235
Special notes for your reviewer:
This PR demonstrates the scenario which is problematic on 1.28, which does not contain the fix yet: #121147.
This PR tests on github CI the new test when the fix is reverted: #122262
Here is the failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/122262/pull-kubernetes-unit/1734157708581408768
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: