Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for Job Controller for panic when PodFailurePolicy is used on 1.28 #122261

Merged

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Dec 11, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #122235

Special notes for your reviewer:

This PR demonstrates the scenario which is problematic on 1.28, which does not contain the fix yet: #121147.

This PR tests on github CI the new test when the fix is reverted: #122262
Here is the failure: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/122262/pull-kubernetes-unit/1734157708581408768

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.29 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.29.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Dec 11 04:18:32 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Dec 11, 2023
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 11, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Dec 11, 2023

/assign @kannon92
/cc @alculquicondor

@kannon92
Copy link
Contributor

/triage accepted
/priority important-soon

/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3319d034e2f5355537e416c7bb8250e62e3d77a8

@alculquicondor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Dec 11, 2023

@soltysh can we get the 1.29 milestone for it, so that it can merge and be cherry-picked along with #122267

@soltysh
Copy link
Contributor

soltysh commented Dec 11, 2023

@soltysh can we get the 1.29 milestone for it, so that it can merge and be cherry-picked along with #122267

We're only hours before the final release, so I think it can't land. Let's merge this into master as soon as it opens up.

@soltysh
Copy link
Contributor

soltysh commented Dec 11, 2023

If necessary we can just backport afterwards

@k8s-ci-robot k8s-ci-robot merged commit d687dc4 into kubernetes:master Dec 14, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 14, 2023
k8s-ci-robot added a commit that referenced this pull request Dec 21, 2023
…61-upstream-release-1.28

Automated cherry pick of #122261: Add unit test for Job Controller for panic when PodFailurePolicy is used
k8s-ci-robot added a commit that referenced this pull request Dec 21, 2023
…61-upstream-release-1.29

Automated cherry pick of #122261: Add unit test for Job Controller for panic when PodFailurePolicy is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants