Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

re-create unit tests for the scheduling queue for the cases QueueingHint disabled #122304

Closed
sanposhiho opened this issue Dec 14, 2023 · 3 comments · Fixed by #122311
Closed

re-create unit tests for the scheduling queue for the cases QueueingHint disabled #122304

sanposhiho opened this issue Dec 14, 2023 · 3 comments · Fixed by #122311
Assignees
@nayihz
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@sanposhiho
Copy link
Member

sanposhiho commented Dec 14, 2023 •
edited

ref: #122289 (comment)
/sig scheduling
/kind cleanup

Part of: #122284 (comment).

The unit test TestPriorityQueue_MoveAllToActiveOrBackoffQueue in the scheduling queue only assumes the case where the queueing hint is enabled. We should make another unit test to confirm MoveAllToActiveOrBackoffQueue works without QHint.
TestPriorityQueue_MoveAllToActiveOrBackoffQueue should have been existing since before we introduced QHint. So, just bring the old one back should be fine.
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanposhiho sanposhiho mentioned this issue Dec 14, 2023
Closed
@sanposhiho
Copy link
Member Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 14, 2023
@nayihz
Copy link
Contributor

nayihz commented Dec 14, 2023

/assign

@nayihz nayihz mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nayihz nayihz

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add unit test for the scheduling queue for QueueingHint disabled nayihz/kubernetes
3 participants
@k8s-ci-robot @sanposhiho @nayihz