Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use build-in max and min func to instead of k8s.io/utils/integer funcs #122310

Merged
merged 1 commit into from Dec 18, 2023
Merged

use build-in max and min func to instead of k8s.io/utils/integer funcs #122310

merged 1 commit into from Dec 18, 2023

Conversation

weilaaa
Copy link
Member

@weilaaa weilaaa commented Dec 14, 2023 •
edited by liggitt

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

These methods of "k8s.io/utils/integer" are no longer needed as the addition of the built-in max and min methods. So replace them of build-in min and max methods.

Which issue(s) this PR fixes:

Fixes None

Does this PR introduce a user-facing change?

None

cc @liggitt

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/kubectl labels Dec 14, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2023
@weilaaa
Copy link
Member Author

weilaaa commented Dec 14, 2023

/retest

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Dec 14, 2023
HirazawaUi
HirazawaUi reviewed Dec 14, 2023
View reviewed changes
pkg/controller/deployment/rolling.go Outdated Show resolved Hide resolved
pkg/controller/deployment/rolling.go Outdated Show resolved Hide resolved
@Jefftree
Copy link
Member

/assign @jiahuif
Would you mind taking a look at this? Thanks!
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2023
jiahuif
jiahuif reviewed Dec 14, 2023
View reviewed changes
Copy link
Member

@jiahuif jiahuif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks reasonable to me. However, please address comments by @HirazawaUi
/unassign
/assign @HirazawaUi
Re-assigning to existing reviewer. Thank you.

@k8s-ci-robot k8s-ci-robot assigned HirazawaUi and unassigned jiahuif Dec 14, 2023
@HirazawaUi
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7574320a68a0d41ca451777aced5c5c2758cac1f

@yxxhero
Copy link
Member

yxxhero commented Dec 16, 2023

/lgtm

@bart0sh
Copy link
Contributor

bart0sh commented Dec 17, 2023

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 17, 2023
@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Dec 17, 2023
@weilaaa
Copy link
Member Author

weilaaa commented Dec 18, 2023

@alculquicondor, @deads2k, @mrunalp PTAL, need approve :)

@alculquicondor
Copy link
Member

/approve

1 similar comment
@liggitt
Copy link
Member

liggitt commented Dec 18, 2023

/approve

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt, weilaaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2b5c0c2 into kubernetes:master Dec 18, 2023
14 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Dec 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiahuif jiahuif jiahuif left review comments

@HirazawaUi HirazawaUi HirazawaUi left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@yxxhero yxxhero

@HirazawaUi HirazawaUi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
SIG CLI
Archived in project
SIG Node PR Triage
Done
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@weilaaa @Jefftree @HirazawaUi @k8s-ci-robot @yxxhero @bart0sh @alculquicondor @liggitt @jiahuif