Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Scheduler first fit" #122317

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Revert "Scheduler first fit" #122317

merged 1 commit into from
Dec 14, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Dec 14, 2023

Reverts #122058

fixes #122312

Try to stress the UT to reproduce the flake locally.

  • fix the flake and submit again?

cc @aleksandra-malinowska

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Dec 14, 2023

/priority important-soon
as the flake rate is ~4/21 20%
/release-note-none
/kind flake
/cc @aleksandra-malinowska @ahg-g
/assign @sanposhiho

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 14, 2023
@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 14, 2023
@sanposhiho
Copy link
Member

sanposhiho commented Dec 14, 2023 •
edited

/lgtm
/approve
/release-note-none

failed 4 in last ~20 runs, a very high flake rate.

Given this fact, I agree to just revert it for now. I checked the PR, but it's just a performance enhancement and safe to revert. We can investigate later about the fix for this test case.

/cc @alculquicondor @aleksandra-malinowska

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca641a502a125155ad625654e86df18221605b2f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@sanposhiho sanposhiho mentioned this pull request Dec 14, 2023
Closed
@k8s-ci-robot k8s-ci-robot merged commit 84b4972 into kubernetes:master Dec 14, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 14, 2023
@aleksandra-malinowska aleksandra-malinowska mentioned this pull request Dec 21, 2023
Merged
@pacoxu pacoxu mentioned this pull request Dec 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

@ahg-g ahg-g Awaiting requested review from ahg-g

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

[Flaking Test] [sig-scheduling] TestSchedulerSchedulePod
3 participants
@pacoxu @k8s-ci-robot @sanposhiho