Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Patcher tolerant of OpenAPIGetter being nil #122346

Merged
merged 1 commit into from Dec 27, 2023
Merged

Make Patcher tolerant of OpenAPIGetter being nil #122346

merged 1 commit into from Dec 27, 2023

Conversation

Jefftree
Copy link
Member

@Jefftree Jefftree commented Dec 15, 2023 •
edited

What type of PR is this?

/kind regression

What this PR does / why we need it:

Make Patcher tolerant of OpenAPIGetter being nil.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix an issue where kubectl apply could panic when imported as a library

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 15, 2023
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 15, 2023
Jefftree referenced this pull request Dec 15, 2023
@Jefftree
Lazy load OpenAPIV2
eb32969
@tomasaschan tomasaschan mentioned this pull request Dec 19, 2023
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 20, 2023
@Jefftree
Copy link
Member Author

/assign @seans3

@ardaguclu ardaguclu mentioned this pull request Dec 22, 2023
Closed
@ardaguclu
Copy link
Member

I assume that panicked cluster does not use OpenAPI v3 and fell back to v2 but I'm not sure how OpenAPIGetter can be nil. On the other hand, change looks good to me because we shouldn't panic any case;

/approve
/lgtm
/hold
in case you'd want another set of eyes, otherwise, feel free to unhold @Jefftree

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 22, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b3cc8de11dd6a59bff637d5439033fa8032d514c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, Jefftree, tomasaschan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2023
@Jefftree
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1b6b3ba into kubernetes:master Dec 27, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Dec 27, 2023
@Jefftree Jefftree mentioned this pull request Jan 2, 2024
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 10, 2024
@k8s-ci-robot
Merge pull request #122559 from Jefftree/automated-cherry-pick-of-#12…
73b4bf2 
…2346-upstream-release-1.29

Automated cherry pick of #122346: Make OpenAPIGetter tolerant of nil
@Jefftree Jefftree deleted the patcher-fix-openapigetter-nil branch January 25, 2024 22:22
tomasaschan added a commit to tomasaschan/kubebuilder-declarative-pattern that referenced this pull request Feb 7, 2024
@tomasaschan
Bump k8s.io/kubectl to 0.29.1
8996c30 
Main motivation is to include kubernetes/kubernetes#122346
@tomasaschan tomasaschan mentioned this pull request Feb 7, 2024
Closed
@liggitt liggitt removed the kind/regression Categorizes issue or PR as related to a regression from a prior release. label Mar 27, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasaschan tomasaschan tomasaschan approved these changes

@brianpursley brianpursley Awaiting requested review from brianpursley

@mpuckett159 mpuckett159 Awaiting requested review from mpuckett159

Assignees

@seans3 seans3

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG CLI
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jefftree @ardaguclu @k8s-ci-robot @tomasaschan @liggitt @seans3