New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduler first fit #122435
Scheduler first fit #122435
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Flakes should be gone now:
|
/lgtm |
LGTM label has been added. Git tree hash: dfc829cf71cd090cfd82a8d8f582343fe1fe8fc0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, aleksandra-malinowska The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Have you tried stress to reproduce the flake? This adding test https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-unit/1740254928200273920 flakes in master blocking test grid. I opened #122505 to track the new flake. Read more in https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/flaky-tests.md. |
This was reverted in #123290 |
Resubmit of #122058, reverted in #122317 due to a flaky test
Test is fixed now - there was a typo,
node3
instead ofnode2
was listed as one of expected results.What type of PR is this?
/kind bug
What this PR does / why we need it:
Skip looking for extra nodes if no scoring plugins are defined. As there's no difference in priority between nodes when we don't score them, there's no point in searching for multiple fitting nodes.
Which issue(s) this PR fixes:
Fixes #122057
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig scheduling
/cc @ahg-g