Initial impl. of cloud provider for AWS

[ragnard]

Sumitting the pull request discussed in issue #1187 for initial review and more feedback.

Implements only the cloudprovider.Instances interface for now.

New dependencies:

• https://github.com/mitchellh/goamz: for talking to AWS API
• https://code.google.com/p/gcfg/: for reading cloud provider configuration (as suggested in issue)

Caveats:

• DNS name used is private DNS names (kubernetes should run in VPC)
• filtering is done on the Name tag (private DNS is auto-assigned and not something you can affect)
  • should move away from regexp in order to better leverage cloud provider specific filtering capabilities (tags for AWS)

Configuration file is in INI format (as implemented by gcfg) and currently has only one (required) configuration option, the region:

[global]
region = eu-west-1

[bgrant0607]

@jbeda @lavalamp @thockin Any volunteers to take a look at this, or suggest a reviewer?

[lavalamp]

@ragnard first, thanks a ton for this. Second, can you put the new dependencies and the other changes into separate commits? It's really hard to look at the important stuff in the github diff view when it's all together.

[lavalamp]

I also suspect I'm going to ask for tests :)

[ragnard]

Syre, will do that. I'm UTC+0 so probably tomorrow...
On 9 Sep 2014 19:06, "Daniel Smith" notifications@github.com wrote:

@ragnard https://github.com/ragnard first, thanks a ton for this.
Second, can you put the new dependencies and the other changes into
separate commits? It's really hard to look at the important stuff in the
github diff view when it's all together.

—
Reply to this email directly or view it on GitHub
#1229 (comment)
.

[ragnard]

Updated with separate commits for dependencies and cloud provider impl.

[ragnard]

@lavalamp Regarding tests, I'm not sure what (if anything) is a good fit for unit testing in these commits. Did you have any specific concerns or suggestions? If so, I'd be happy to address them.

[lavalamp]

@ragnard I'm willing to take this without tests, because it's still an improvement over not having it--

But I think readAWSCloudConfig, IPAddress, and getInstancesByRegex functions could use tests; for the latter two, you'd provide a fake/mock ec2 and verify that the functions are doing the right thing. This would help keep us from breaking the behavior should we do a refactor of the cloudprovider interface.

[ragnard]

@lavalamp Added some tests. This is basically the first Go code I'm writing so I'm probably missing some stuff. I extracted an interface for the EC2 interactions I'm doing, implemented that using the goamz/ec2 package, and used another, fake, implementation for the List test. Not to happy with how that turned out so I haven't added test for the other method (IPAddress) yet. Would be grateful for feedback/pointers.

[lavalamp]

@ragnard Actually it looks pretty good, I left a few suggestions but you're basically doing it right.

[ragnard]

@lavalamp Updated tests after suggestions. Added test for IPAddress.

[lavalamp]

LGTM