Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix license verification script #122956

Merged
merged 2 commits into from Jan 25, 2024
Merged

Fix license verification script #122956

merged 2 commits into from Jan 25, 2024

Conversation

dims
Copy link
Member

@dims dims commented Jan 25, 2024

get kubernetes-verify-go-licenses-periodical back on its feet

https://testgrid.k8s.io/sig-testing-misc#kubernetes-verify-go-licenses-periodical&width=20

  • Avoid the print and then grep, seems to be unreliable, just do it from a file
  • Collect intermediate artifacts and the error logs for further analysis

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 25, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 25, 2024
@dims
Copy link
Member Author

dims commented Jan 25, 2024

/assign @Priyankasaggu11929 @ameukam @upodroid

@dims
Copy link
Member Author

dims commented Jan 25, 2024

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 25, 2024
@dims
collect generated files and logs
89db64e 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the fix-license-verification-script branch from 1b420fd to 89db64e Compare January 25, 2024 12:23
upodroid
upodroid approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e6fcbf5efd1ad4e2725b0b9f6957513c8d1e7c6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member

ameukam commented Jan 25, 2024

/lgtm

@liggitt
Copy link
Member

liggitt commented Jan 25, 2024

will defer to @ameukam's review and lgtm, but is there a way to see this run green before merge, since I assume failures are not blocking or surfacing in presubmits by default?

@k8s-ci-robot k8s-ci-robot merged commit 192e535 into kubernetes:master Jan 25, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 25, 2024
@dims
Copy link
Member Author

dims commented Jan 26, 2024

@liggitt this script doesn't run in presubmits and does not block anything. It's now green 🟩

https://testgrid.k8s.io/sig-testing-misc#kubernetes-verify-go-licenses-periodical&width=20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@hwdef hwdef Awaiting requested review from hwdef

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@ameukam ameukam

@upodroid upodroid

@Priyankasaggu11929 Priyankasaggu11929

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dims @k8s-ci-robot @ameukam @liggitt @upodroid @Priyankasaggu11929