Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e test test should assign default SC to PVCs that have no SC set failure #123051

Merged
merged 1 commit into from Feb 19, 2024

Conversation

yangjunmyfm192085
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

When the cluster exists storageclass.kubernetes.io/is-default-class: "true" When annotating the storage class, the e2e test case test should assign default SC to PVCs that have no SC set reports an error.

   Jan 31 14:06:57.427: INFO: Success - PersistentVolumeClaim retro-pvc-krf4d got updated retroactively with StorageClass retroqr5w4
   Jan 31 14:06:57.442: INFO: Unexpected error:
       <*errors.StatusError | 0xc0006fc8c0>:
       Operation cannot be fulfilled on storageclasses.storage.k8s.io "provisioning-nfs": the object has been modified; please apply your changes to the latest version and try again
       {
           ErrStatus:
               code: 409
               details:
                 group: storage.k8s.io
                 kind: storageclasses
                 name: provisioning-nfs
               message: 'Operation cannot be fulfilled on storageclasses.storage.k8s.io "provisioning-nfs":
                 the object has been modified; please apply your changes to the latest version and
                 try again'
               metadata: {}
               reason: Conflict
               status: Failure,
       }
   [FAILED] in [It] - test/e2e/storage/pvc_storageclass.go:152 @ 01/31/24 14:06:57.442

Does this PR introduce a user-facing change?

"NONE"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 31, 2024
@yangjunmyfm192085
Copy link
Contributor Author

/cc @pohly

@mattcary
Copy link
Contributor

/lgtm

thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 05fb8ba27d884c441977be95a48d41313230c7e1

@yangjunmyfm192085
Copy link
Contributor Author

/retest

Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test pull-kubernetes-e2e-kind

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7090b9d into kubernetes:master Feb 19, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants