kubeadm: enhance encryption algorithm support in v1beta4 #123054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
/hold for review |
k8s-ci-robot
added
do-not-merge/hold
|
/cc @pacoxu @randomvariable |
k8s-ci-robot
requested review from
pacoxu,
randomvariable,
chendave and
SataQiu
k8s-ci-robot
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9d9695fd56aa0faabfba46fd5fc8b33f06f8aaa3
|
neolit123
force-pushed
the
1.30-v1beta4-encryption-enhance
branch
from
d3810a6
to
9b401c8
Compare
k8s-ci-robot
removed
the
lgtm
neolit123
force-pushed
the
1.30-v1beta4-encryption-enhance
branch
from
9b401c8
to
7667221
Compare
Previous v1beta4 work added support for ClusterConfiguration.EncryptionAlgorithm, however the possible values were limited to just "RSA" (2048 key size) and "ECDSA" (P256). Allow more arbitrary algorithm types, that can also include key size or curve type encoded in the name: "RSA-2048" (default), "RSA-3072", "RSA-4096" or "ECDSA-P256". Update the deprecation notice of the PublicKeysECDSA FeatureGate as ideally it should be removed only after v1beta3 is removed.
neolit123
force-pushed
the
1.30-v1beta4-encryption-enhance
branch
from
7667221
to
2cab797
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5d50ace707c57c9a3c2ee4886b9215441083afbf
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, SataQiu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Which PR has the changelog entry for this? |
none yet, when we are about to release v1beta4 we will push a PR with a bug release note that has all the new features in this API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Previous v1beta4 work added support for
ClusterConfiguration.EncryptionAlgorithm, however the possible values were limited to just "RSA" (2048 key size) and "ECDSA" (P256).
Allow more arbitrary algorithm types, that can also include key size or curve type encoded in the name:
"RSA-2048" (default), "RSA-3072", "RSA-4096" or "ECDSA-P256".
Update the deprecation notice of the PublicKeysECDSA FeatureGate as ideally it should be removed only after v1beta3 is removed.
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#3003
see kubernetes/kubeadm#3003 (comment)
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?
(intentionally none)
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: