Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: increase ut coverage for apiclient/idempotency #123118

Merged
merged 1 commit into from Feb 5, 2024
Merged

kubeadm: increase ut coverage for apiclient/idempotency #123118

merged 1 commit into from Feb 5, 2024

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Feb 4, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

kubeadm: increase ut coverage for apiclient/idempotency

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 4, 2024
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 4, 2024
@my-git9
Copy link
Member Author

my-git9 commented Feb 4, 2024

/test pull-kubernetes-unit
/test pull-kubernetes-node-e2e-containerd

neolit123
neolit123 reviewed Feb 4, 2024
View reviewed changes
cmd/kubeadm/app/util/apiclient/idempotency_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/apiclient/idempotency_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/apiclient/idempotency_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/apiclient/idempotency_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/apiclient/idempotency_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/apiclient/idempotency_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/apiclient/idempotency_test.go
}
}

func newMockClientForTest(t *testing.T, namepsace string, name string, kind string) *fake.Clientset {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW instead of using such a function it's simpler to use reactors.

https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/phases/kubeconfig/kubeconfig_test.go#L838-L840
https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/phases/kubeconfig/kubeconfig_test.go#L936-L937

but the way you are doing it is also OK.

@neolit123
Copy link
Member

/triage accepted
/priority backlog
/approve

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: my-git9, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2024
@my-git9 my-git9 force-pushed the idempotency-ut branch 2 times, most recently from b61df54 to 2d4511a Compare February 5, 2024 14:42
neolit123
neolit123 reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two more minor comments, but LGTM

cmd/kubeadm/app/util/apiclient/idempotency_test.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/util/apiclient/idempotency_test.go Outdated Show resolved Hide resolved
@my-git9
kubeadm: increase ut coverage for apiclient/idempotency
deec79a 
Signed-off-by: xin.li <xin.li@daocloud.io>
neolit123
neolit123 reviewed Feb 5, 2024
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f8aff09c267d6b54d72cc8b22d49d83401f71e1a

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit dd301d0 into kubernetes:master Feb 5, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@chendave chendave Awaiting requested review from chendave

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@my-git9 @neolit123 @k8s-ci-robot @k8s-triage-robot