Add an earlier check and error for names that won't work for services. #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandburns
force-pushed
the
service
branch
from
c65fc90
to
2789d3e
Compare
| @@ -174,6 +175,9 @@ func portsFromString(spec string) []api.Port { | |||
|
|
|||
| // RunController creates a new replication controller named 'name' which creates 'replicas' pods running 'image'. | |||
| func RunController(image, name string, replicas int, client client.Interface, portSpec string, servicePort int) error { | |||
| if servicePort > 0 && !util.IsDNSLabel(name) { | |||
| return fmt.Errorf("Service creation requested, but an invalid name for a service was provided (%s). Service names must be valid DNS labels.") | |||
There was a problem hiding this comment.
Don't you need to pass the name for the %s?
brendandburns
force-pushed
the
service
branch
from
2789d3e
to
80c06f4
Compare
|
LGTM |
bgrant0607
added a commit
that referenced
this pull request
Sep 10, 2014
Add an earlier check and error for names that won't work for services.
csrwng
pushed a commit
to csrwng/kubernetes
that referenced
this pull request
Apr 13, 2022
…vileged UPSTREAM: 109283: test/e2e/*: use restricted policy by default, default existing tests to privileged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1013