Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for TestStorageVersionMigrationWithCRD integration test failure #123983

Merged
merged 1 commit into from Mar 19, 2024

Conversation

aramase
Copy link
Member

@aramase aramase commented Mar 19, 2024

What type of PR is this?

/kind flake

What this PR does / why we need it:

Looking at the logs, the actual failure is here

 util.go:1008: Failed to create CR: client rate limiter Wait returned an error: context deadline exceeded

crdUnstructured, err := svm.dynamicClient.Resource(crdResource).Namespace(defaultNamespace).Create(ctx, crdUnstructured, metav1.CreateOptions{})
if err != nil {
t.Fatalf("Failed to create CR: %v", err)
}

that's from

err := wait.PollUntilContextTimeout(
ctx,
500*time.Millisecond,
wait.ForeverTestTimeout,
true,
func(ctx context.Context) (bool, error) {
triggerCR := svm.createCR(ctx, t, "triggercr", "v1")
svm.deleteCR(ctx, t, triggerCR.GetName(), "v1")
svmResource, err := svm.getSVM(ctx, t, crdSVMName)

which is failing after the 30s context deadline. Increasing the timeout to wait for migration to complete.

Which issue(s) this PR fixes:

Fixes #123921

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 19, 2024
@aramase
Copy link
Member Author

aramase commented Mar 19, 2024

/sig api-machinery
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 19, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 19, 2024
@aramase
Copy link
Member Author

aramase commented Mar 19, 2024

/cc @enj

@k8s-ci-robot k8s-ci-robot requested a review from enj March 19, 2024 05:03
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@SataQiu
Copy link
Member

SataQiu commented Mar 19, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d32de55c131bc322674bdfccb83ec5987f6a8cac

@enj
Copy link
Member

enj commented Mar 19, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, enj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
@enj
Copy link
Member

enj commented Mar 19, 2024

/milestone v1.30

(fixing flaking test)

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 1f3c65c into kubernetes:master Mar 19, 2024
15 checks passed
@aramase aramase deleted the aramase/i/123921_flake_fix branch March 19, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaking Test] integration TestStorageVersionMigrationWithCRD
4 participants