fix test flake caused by not waiting for CRD schema update #124019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
kind/failing-test
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
LGTM label has been added. Git tree hash: d0560d45fd95567094cc79060062fc5a795680af
|
liggitt
reviewed
Mar 29, 2024
staging/src/k8s.io/apiextensions-apiserver/test/integration/ratcheting_test.go
Show resolved
Hide resolved
liggitt
reviewed
Mar 29, 2024
staging/src/k8s.io/apiextensions-apiserver/test/integration/ratcheting_test.go
Outdated
Show resolved
Hide resolved
liggitt
reviewed
Mar 29, 2024
staging/src/k8s.io/apiextensions-apiserver/test/integration/ratcheting_test.go
Outdated
Show resolved
Hide resolved
alexzielenski
force-pushed
the
fix-ratcheting-flake
branch
from
a2df5d8
to
a7933dc
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
requested review from
deads2k,
Jefftree,
jiahuif,
jpbetz and
liggitt
|
feedback addressed |
alexzielenski
force-pushed
the
fix-ratcheting-flake
branch
from
a7933dc
to
0add741
Compare
Yes. This flake ~ once a day in https://testgrid.k8s.io/sig-release-master-blocking#integration-master. |
|
/lgtm test-only fix for the flakiest integration test we currently have |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: c8643e0c4398b5864210fdb9c78bb089d8ff56a0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind failing-test
/kind flake
What this PR does / why we need it:
Fixes a flake in some test code. Flake was caused by our check to make sure CRD schema was updated. We would check to see a returned error had special string, but the error message would unconditionally contain the string since we had used within the send value, so we never would actually wait....I'm surprised it did not flake more than it had.
FIxed by no longer sending the special string in with the object, and instead encoding the special string as a custom CEL error message. This is a better way of checking that the new schema is being updated.
Which issue(s) this PR fixes:
Fixes #123854
Special notes for your reviewer:
/assign @Jefftree
/cc @pacoxu
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: