Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRA: E2E: add test case for structured parameters + deallocation #124024

Open
pohly opened this issue Mar 22, 2024 · 2 comments
Open

DRA: E2E: add test case for structured parameters + deallocation #124024

pohly opened this issue Mar 22, 2024 · 2 comments
Assignees
@pohly
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board

Comments

@pohly
Copy link
Contributor

pohly commented Mar 22, 2024

What would you like to be added?

kubernetes/test/e2e/dra/dra.go

Line 666 in 95a6f2e

ginkgo.Context("reallocation", func() {
covers the PostFilter code path in the scheduler.

We need a corresponding E2E test for structured parameters. How to trigger it in a realistic way is a bit open. It probably can occur in combination with some other PreBind plugin or a write error during PreBind (both not easy to simulate). Perhaps we simply need to set up a claim in the right starting state.

Why is this needed?

Unit tests alone are not sufficient.
@pohly pohly added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 22, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2024
@pohly
Copy link
Contributor Author

pohly commented Mar 22, 2024

/sig node
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 22, 2024
@pohly pohly mentioned this issue Mar 22, 2024
Merged
@bart0sh bart0sh added this to Triage in SIG Node CI/Test Board Mar 24, 2024
@SergeyKanzhelev
Copy link
Member

/assign @pohly

since there is a PR for it.

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to Issues - In progress in SIG Node CI/Test Board Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pohly pohly

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Issues - In progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pohly @SergeyKanzhelev @k8s-ci-robot