Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaking Test] [sig-auth] integration-master TestMultiWebhookAuthzConfig #124107

Closed
pacoxu opened this issue Mar 29, 2024 · 5 comments · Fixed by #124111
Closed

[Flaking Test] [sig-auth] integration-master TestMultiWebhookAuthzConfig #124107

pacoxu opened this issue Mar 29, 2024 · 5 comments · Fixed by #124111
Labels
kind/flake Categorizes issue or PR as related to a flaky test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth.

Comments

@pacoxu
Copy link
Member

pacoxu commented Mar 29, 2024

Which jobs are flaking?

  • ci-kubernetes-integration-master

Which tests are flaking?

--- FAIL: TestMultiWebhookAuthzConfig (9.23s)
k8s.io/kubernetes/test/integration/auth.auth

Since when has it been flaking?

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-integration-master/1770274294463467520
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-integration-master/1773485209702895616 (03-20)

I cannot search for previous flake.

Testgrid link

https://testgrid.k8s.io/sig-release-master-blocking#integration-master

Reason for failure (if possible)

    authz_config_test.go:669: failure timestamp changed from reload1Metrics.reloadFailure 2024-03-28 23:27:10.466200351 +0000 UTC to 2024-03-28 23:27:10.953506469 +0000 UTC unexpectedly

Anything else we need to know?

https://github.com/kubernetes/kubernetes/blame/f4e246bc93ffb68b33ed67c7896c379efa4207e7/test/integration/auth/authz_config_test.go#L124
updated recently

Relevant SIG(s)

/sig auth
/cc @liggitt

@pacoxu pacoxu added the kind/flake Categorizes issue or PR as related to a flaky test. label Mar 29, 2024
@k8s-ci-robot k8s-ci-robot added the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Mar 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 29, 2024
@liggitt
Copy link
Member

liggitt commented Mar 29, 2024

Updated the description, the actual cause of the flake is an unexpected change in the file reload timestamp metric

@liggitt
Copy link
Member

liggitt commented Mar 29, 2024

interestingly, https://storage.googleapis.com/k8s-triage/index.html?pr=1&test=k8s.io%2Fkubernetes%2Ftest%2Fintegration%2Fauth.auth doesn't show any failures of this test for this reason (there are a few failures on a PR that broke a bunch of integration tests for a different reason)

@liggitt
Copy link
Member

liggitt commented Mar 29, 2024

Fix open in #124111, switched the file write to an atomic write

@pacoxu
Copy link
Member Author

pacoxu commented Apr 1, 2024

Fix open in #124111, switched the file write to an atomic write

No flake after 03-29. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/flake Categorizes issue or PR as related to a flaky test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/auth Categorizes an issue or PR as relevant to SIG Auth.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants