Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename mergo module in clientcmd #124279

Open
tessapham opened this issue Apr 11, 2024 · 4 comments
Open

rename mergo module in clientcmd #124279

tessapham opened this issue Apr 11, 2024 · 4 comments
Assignees
@tessapham
Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@tessapham
Copy link

What would you like to be added?

Module github.com/imdario/mergo has been renamed as dario.cat/mergo and should be updated in kubernetes/client-go/clientcmd.

Why is this needed?

It's causing warnings when we run go mod tidy in repos that call client-go/clientcmd.
@tessapham tessapham added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 11, 2024
@tessapham tessapham changed the title rename mergo module rename mergo module in clientcmd Apr 11, 2024
@tessapham tessapham mentioned this issue Apr 11, 2024
Closed
@neolit123
Copy link
Member

Module github.com/imdario/mergo has been renamed as dario.cat/mergo and should be updated in kubernetes/client-go/clientcmd.

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 11, 2024
@BenTheElder
Copy link
Member

/triage accepted
/assign @tessapham

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 16, 2024
@BenTheElder BenTheElder added the area/code-organization Issues or PRs related to kubernetes code organization label Apr 16, 2024
@dims
Copy link
Member

dims commented May 11, 2024

xref: kubernetes-sigs/kustomize#5044

@dims dims mentioned this issue May 11, 2024
Closed
@dims
Copy link
Member

dims commented May 13, 2024

some stuff already discussed like:
#107499 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tessapham tessapham

Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update mergo module in client-go tessapham/kubernetes
5 participants
@dims @neolit123 @BenTheElder @k8s-ci-robot @tessapham