Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support .spec.providerID as a field-selector for Nodes #124348

Open
cskinfill opened this issue Apr 17, 2024 · 5 comments
Open

support .spec.providerID as a field-selector for Nodes #124348

cskinfill opened this issue Apr 17, 2024 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@cskinfill
Copy link

What would you like to be added?

I would like to be able to select nodes based on the .spec.providerID field.

something like kubectl get node --field-selector spec.providerID=aws://us-east-1a/someId

Why is this needed?

This would be useful in the case that I have a cloud provider ID for the node's host (EC2 instance for example), but I don't have a clear way to map that to the Node's name.

@cskinfill cskinfill added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 17, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member

aojea commented Apr 17, 2024

AFAIK the id is not well specified and provider specific

// ID of the node assigned by the cloud provider in the format: <ProviderName>://<ProviderSpecificNodeID>
// +optional
ProviderID string `json:"providerID,omitempty" protobuf:"bytes,3,opt,name=providerID"`

Also, what will be the case that is easier to get the providerID than the node name?

@neolit123
Copy link
Member

/sig cloud-provider node

@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 18, 2024
@Sheikh-Abubaker
Copy link

AFAIK the id is not well specified and provider specific

// ID of the node assigned by the cloud provider in the format: <ProviderName>://<ProviderSpecificNodeID>
// +optional
ProviderID string `json:"providerID,omitempty" protobuf:"bytes,3,opt,name=providerID"`

Also, what will be the case that is easier to get the providerID than the node name?

@aojea since the providerID is already there is this issue still relevant ?

@aojea
Copy link
Member

aojea commented Apr 21, 2024

@aojea since the providerID is already there is this issue still relevant ?

it needs to create an index in memory in the apiserver and this has a cost, but let's summon @wojtek-t that is the expert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

5 participants