Garbage collector can create invalid virtual nodes

[Airblader]

What happened?

Disclaimer: I came across this when studying the GC code, but haven't observed the issue directly (or tried to).

In GraphBuilder#addDependentToOwners, a virtual node is created if the owner hasn't been observed in the graph yet. However, it blindly uses the dependent's namespace for this owner node. This will be incorrect if the owner is a non-namespaced resource.

See

kubernetes/pkg/controller/garbagecollector/graph_builder.go

Line 411 in 183aca3

Namespace: n.identity.Namespace,

.

I'm reporting this as a kind of low-effort thing as I do not have capacity of interest in resolving this myself. Feel free to close if it doesn't meet community standards.

What did you expect to happen?

How can we reproduce it (as minimally and precisely as possible)?

Anything else we need to know?

Kubernetes version

$ kubectl version
# paste output here

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[neolit123]

/sig node

[kannon92]

/remove-sig node
/sig apps