Do not clean Job tracking finalizer for Pods owned by non-batch/Job

[mimowo]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Discovered during #123273, where we decided that the finalizer should not be deleted from Job, if the owner is a batch Job with a custom managedBy.

Does this PR introduce a user-facing change?

Do not remove the "batch.kubernetes.io/job-tracking" finalizer from a Pod, in a corner
case scenario, when the Pod is controlled by an API object which is not a batch Job
(e.g. when the Pod is controlled by a custom CRD).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mimowo]

/assign @atiratree

[mimowo]

/cc @alculquicondor

[mimowo]

Many tests fail, I will need to investigate why, marking as WIP.

EDIT: fixed by another approach, as here.

[mimowo]

/test pull-kubernetes-e2e-kind-ipv6
Unrelated failure of "[sig-node] Mount propagation should propagate mounts within defined scopes"

[atiratree]

Can you also squash the commits and make the release note more readable (#124798 (comment))?

otherwise lgtm

[mimowo]

@atiratree I squashed the PR and updated the release note. PTAL

[atiratree]

thx!
/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: cf2f35fd0be97e1cbc4ad1c15727681f849eff54

[atiratree]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/job/OWNERS [atiratree]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest