-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate Tolerations #124881
Comments
/sig api-machinery |
/cc |
/assign |
/triage accepted |
Is this a feature request? Sounds like a bug, but I'm not sure. |
I don't know if its a bug but it is certainly an irritation... I have prometheus logging a warning in ~18 k8s clusters because of this every 30s. |
That's why I downgraded to v2.51.2. the duplication warning was introduced in v2.52.0. |
What would you like to be added?
I have encountered an issue where duplicate tolerations exist within the tolerations array of Kubernetes Deployment YAML. Despite being duplicates, these tolerations are not being ignored as I would have expected, which in my case led to duplicate metric samples produced by the kube-state-metrics.
A validation check within the Kubernetes API server to reject manifests with duplicate tolerations, ensuring adherence to Kubernetes best practices and avoiding potential issues related to duplicate toleration definitions would be great.
The whole thing was noticed after the update to prometheus v2.52.0 which includes a new check for duplicates during the scrape phase. I created the following issue for that prometheus/prometheus#14089
I have meanwhile also created an issue for the kube-state-metrics project requesting some changes in order to tackle such situations in the future. kubernetes/kube-state-metrics#2390
Steps to reproduce:
2.) Check the tolerations of the scheduled pod for instance:
Why is this needed?
Duplicate tolerations are not being ignored and are applied to resources, potentially resulting in unintended behaviors.
The text was updated successfully, but these errors were encountered: