RuntimeHandlerResolver: interface invalid nil checking

[augustoezq]

What happened?

the nil checking for interface RuntimeHandlerResolver in #L109 will never check whether the underlying struct is nil.
A reflect nil checking is needed to avoid panic in running 'rcManager.LookupRuntimeHandler'(#L111)

kubernetes/pkg/kubelet/kuberuntime/util/util.go

Lines 107 to 115 in a3a4988

	func NamespacesForPod(pod *v1.Pod, runtimeHelper kubecontainer.RuntimeHelper, rcManager RuntimeHandlerResolver) (*runtimeapi.NamespaceOption, error) {
	runtimeHandler := ""
	if pod != nil && rcManager != nil {
	var err error
	runtimeHandler, err = rcManager.LookupRuntimeHandler(pod.Spec.RuntimeClassName)
	if err != nil {
	return nil, err
	}
	}

What did you expect to happen?

Add reflect nil checking for rcManager

How can we reproduce it (as minimally and precisely as possible)?

1. kubelet enable standaloneMode
2. pod.Spec.SecurityContext not nil

Anything else we need to know?

No response

Kubernetes version

master

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zhifei92]

Thank you for reporting the issue, I will create a PR to fix it.

[zhifei92]

/assign

[zhifei92]

/sig node

[ThereWeGo]

@augustoezq 你好 借一层楼 我有个aliyun eci-profile 相关的问题想请教 如果方便请与我取得联系 谢谢 gblogbd@qq.com