Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make-release-notes.sh (in kubernetes/contrib) #13343

Closed
zmerlynn opened this issue Aug 29, 2015 · 3 comments · Fixed by kubernetes-retired/contrib#199
Closed

Fix make-release-notes.sh (in kubernetes/contrib) #13343

zmerlynn opened this issue Aug 29, 2015 · 3 comments · Fixed by kubernetes-retired/contrib#199
Assignees
@ikehz
Labels
area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@zmerlynn
Copy link
Member

The shuffle to contrib means the wrapper script is no longer usable, so relnotes for 1.1.0-alpha.1 are currently lame.
@zmerlynn
Copy link
Member Author

(https://github.com/kubernetes/kubernetes/releases/tag/v1.1.0-alpha.1 needs to be filled in, and I'm OoO next week.)

@zmerlynn zmerlynn mentioned this issue Aug 29, 2015
Closed
4 tasks
@lavalamp lavalamp added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 31, 2015
@ikehz ikehz added area/release-eng Issues or PRs related to the Release Engineering subproject and removed team/none labels Oct 7, 2015
@ikehz ikehz assigned ikehz and unassigned brendandburns Oct 19, 2015
@ikehz ikehz added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Oct 19, 2015
@ikehz
Copy link
Contributor

ikehz commented Oct 19, 2015

Additionally, the script never took into account the possibility that a PR might be updated after it was merged. It sorts on last updated, then when it hits the oldest PR it's looking for, it assumes all others are older, even though they might have been merged after the oldest PR, but before that PR was commented on.

@ikehz ikehz changed the title make-release-notes.sh bitrot after contrib move Fix make-release-notes.sh (in kubernetes/contrib) Oct 20, 2015
@ikehz
Copy link
Contributor

ikehz commented Oct 21, 2015

make-release-notes.sh should also filter on the release-note tag.

This was referenced Oct 22, 2015
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ikehz ikehz

Labels
area/build-release area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the release-notes tool ikehz/contrib
5 participants
@ikehz @lavalamp @zmerlynn @brendandburns @bgrant0607-nocc