Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #16494 upstream release 1.1 #16611

Conversation

mikedanese
Copy link
Member

Automated cherry pick of #16494 upstream release 1.1

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@mikedanese
Copy link
Member Author

This passes unit tests locally

@davidopp
Copy link
Member

LGTM

I have no idea why automatic cherrypick worked for you -- didn't work for me and I went down a huge rathole or trying to manually cherrypick it. Anyway, glad it turned out to be easy -- thanks!

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2015
@davidopp davidopp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 30, 2015

GCE e2e test build/test passed for commit 421bde0.

a-robinson added a commit that referenced this pull request Oct 30, 2015
…6494-upstream-release-1.1

Automated cherry pick of #16494 upstream release 1.1
@a-robinson a-robinson merged commit 44c22b9 into kubernetes:release-1.1 Oct 30, 2015
@mikedanese mikedanese deleted the automated-cherry-pick-of-#16494-upstream-release-1.1 branch October 30, 2015 20:49
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…pick-of-#16494-upstream-release-1.1

Automated cherry pick of kubernetes#16494 upstream release 1.1
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…pick-of-#16494-upstream-release-1.1

Automated cherry pick of kubernetes#16494 upstream release 1.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants