Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undefined color_ variables #19749

Merged
merged 1 commit into from
Jan 16, 2016
Merged

Remove undefined color_ variables #19749

merged 1 commit into from
Jan 16, 2016

Conversation

bprashanth
Copy link
Contributor

I'm guessing this is what happened in http://kubekins.dls.corp.google.com/job/kubernetes-e2e-gce-reboot/10502/consoleFull because everything passed except a list operation, which we should've retried.

17:01:39 ++ ./cluster/gce/list-resources.sh
17:01:47 ERROR: (gcloud.compute.instances.list) Some requests did not succeed:
17:01:47  - Internal Error
17:01:47  
17:01:47 ./cluster/gce/list-resources.sh: line 48: color_yellow: unbound variable
17:01:47 Build step 'Execute shell' marked build as failure
17:01:47 Recording test results

I think KUBE_ROOT should be in the env.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 16, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2016
@k8s-bot
Copy link

k8s-bot commented Jan 16, 2016

GCE e2e build/test failed for commit f15ab1ba2492ef1d0f02907f394a4e7a20868e8e.

mikedanese
mikedanese reviewed Jan 16, 2016
View reviewed changes
cluster/gce/list-resources.sh
@@ -30,6 +30,7 @@ ZONE=${ZONE:-}
REGION=${ZONE%-*}
INSTANCE_PREFIX=${KUBE_GCE_INSTANCE_PREFIX:-${CLUSTER_NAME:-}}
NETWORK=${KUBE_GCE_NETWORK:-${KUBE_GKE_NETWORK:-}}
source "${KUBE_ROOT}/cluster/kube-env.sh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KUBE_ROOT is unbound here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspected that, I sould probably source util.sh or something

@bprashanth bprashanth changed the title Source kube-env Remove undefined color_ variables Jan 16, 2016
@bprashanth
Copy link
Contributor Author

Yeah i just removed color_

@mikedanese mikedanese added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 16, 2016
@mikedanese
Copy link
Member

SGTM

@k8s-bot
Copy link

k8s-bot commented Jan 16, 2016

GCE e2e test build/test passed for commit 7a97163.

@mikedanese
Copy link
Member

This will help with a flake.

mikedanese added a commit that referenced this pull request Jan 16, 2016
@mikedanese
Merge pull request #19749 from bprashanth/color
912e54e 
Remove undefined color_ variables
@mikedanese mikedanese merged commit 912e54e into kubernetes:master Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bprashanth @k8s-github-robot @k8s-bot @mikedanese @k8s-teamcity-mesosphere @googlebot