Delete hpa first before deleting the resources it controls in test-cmd.sh #22466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janetkuo
added
priority/critical-urgent
janetkuo
changed the title
|
Labelling this PR as size/XS |
k8s-github-robot
added
the
size/XS
|
LGTM, Thanks! |
bgrant0607
added
the
lgtm
|
@k8s-oncall: I'm going to manually merge this once tests pass in order to fix test flakes. |
|
GCE e2e build/test passed for commit 0c4e13c. |
|
Should the reaper delete the hpa too? |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 0c4e13c. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Mar 3, 2016
Auto commit by PR queue bot
|
@Kargakis The reaper for which resource? |
If we set an hpa for a rc or a deployment (or any resource that supports autoscaling and is reapable for that matter) then the respective reaper would somehow detect that hpa and delete it. Makes sense? |
|
This PR is already included in the release-1.2 branch and does not require cherrypick-ing |
eparis
removed
the
cherry-pick-approved
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21716
cc @kubernetes/kubectl @kubernetes/autoscaling