Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESOS: removing timing constants #22495

Merged
merged 1 commit into from
Mar 4, 2016
Merged

MESOS: removing timing constants #22495

merged 1 commit into from
Mar 4, 2016

Conversation

huang195
Copy link
Contributor

@huang195 huang195 commented Mar 4, 2016

No longer using poll-based mechanism, these constants are no longer used.

@k8s-bot
Copy link

k8s-bot commented Mar 4, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

1 similar comment
@k8s-bot
Copy link

k8s-bot commented Mar 4, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@huang195
Copy link
Contributor Author

huang195 commented Mar 4, 2016

@jdef Removing some dead code

@k8s-bot
Copy link

k8s-bot commented Mar 4, 2016

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2016
@jdef
Copy link
Contributor

jdef commented Mar 4, 2016

@k8s-bot ok to test

@k8s-bot
Copy link

k8s-bot commented Mar 4, 2016

GCE e2e build/test passed for commit 50f3fc8.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@jdef jdef added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge and removed needs-ok-to-merge labels Mar 4, 2016
@jdef
Copy link
Contributor

jdef commented Mar 4, 2016

:shipit: lgtm

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Mar 4, 2016
Merge pull request #22495 from huang195/remove_unused_timing_constants
220b681 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 220b681 into kubernetes:master Mar 4, 2016
@huang195 huang195 deleted the remove_unused_timing_constants branch March 4, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdef jdef

Labels
area/platform/mesos lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@huang195 @k8s-bot @k8s-github-robot @jdef @k8s-teamcity-mesosphere @googlebot