Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in kubectl run help string #22862

Merged
merged 1 commit into from Mar 11, 2016
Merged

Conversation

j3ffml
Copy link
Contributor

@j3ffml j3ffml commented Mar 11, 2016

ref #22849

@k8s-github-robot k8s-github-robot added kind/old-docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@bgrant0607
Copy link
Member

Please run hack/update-generated-docs.sh

<!-- TAG RELEASE_LINK, added by the munger automatically -->
<strong>
The latest release of this document can be found
[here](http://releases.k8s.io/release-1.2/docs/user-guide/kubectl/kubectl_run.md).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened here?

@bgrant0607 bgrant0607 added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 11, 2016
@bgrant0607
Copy link
Member

Thanks
cc @soltysh

@bgrant0607 bgrant0607 added this to the v1.2 milestone Mar 11, 2016
@j3ffml
Copy link
Contributor Author

j3ffml commented Mar 11, 2016

We actually need to fix the update/verify generated docs scripts. We shouldn't be modifying docs in the main repo any more now that they've been moved to the kubernetes.io repo #22863.

@k8s-bot
Copy link

k8s-bot commented Mar 11, 2016

GCE e2e build/test passed for commit fe74ee82ae12c83d727135deb09f66639a89924d.

@k8s-bot
Copy link

k8s-bot commented Mar 11, 2016

GCE e2e build/test passed for commit 627615c.

@bgrant0607
Copy link
Member

LGTM

On generated docs: Yes, the doc move left lots of loose ends. That was one.

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2016
@bgrant0607
Copy link
Member

Manual merge @k8s-oncall

bgrant0607 added a commit that referenced this pull request Mar 11, 2016
fix typo in kubectl run help string
@bgrant0607 bgrant0607 merged commit b7984b2 into kubernetes:master Mar 11, 2016
eparis pushed a commit to eparis/kubernetes that referenced this pull request Mar 11, 2016
fix typo in kubectl run help string
@eparis
Copy link
Contributor

eparis commented Mar 11, 2016

This PR is included in #22874 which is slated to be included in the release-1.2 branch.
Please verify that the cherry-pick in that PR looks correct.

@eparis eparis removed cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Mar 11, 2016
@j3ffml j3ffml deleted the typo branch August 23, 2016 18:42
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
fix typo in kubectl run help string
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
fix typo in kubectl run help string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants