Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rkt: Append tag to the returned image name. #23205

Merged
merged 1 commit into from
Mar 22, 2016
Merged

rkt: Append tag to the returned image name. #23205

merged 1 commit into from
Mar 22, 2016

Conversation

yifan-gu
Copy link
Contributor

This fix makes rkt's returned result matches docker's result, which the image field is "NAME:TAG"

cc @yujuhong @Random-Liu @sjpotter

@yifan-gu yifan-gu added area/rkt sig/node Categorizes an issue or PR as relevant to SIG Node. and removed cla: yes labels Mar 18, 2016
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 18, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 18, 2016

GCE e2e build/test passed for commit fa1fa97c255140c7d9f721c3dccf4f1dafcf0a38.

@k8s-bot
Copy link

k8s-bot commented Mar 18, 2016

GCE e2e build/test passed for commit 57774c57eeb6c9bdb15b4ce2e0da25bd8e83d53f.

@yifan-gu yifan-gu force-pushed the append_image_tag branch 2 times, most recently from 5c0655c to 19f3669 Compare March 18, 2016 20:14
@k8s-bot
Copy link

k8s-bot commented Mar 18, 2016

GCE e2e build/test passed for commit 5c0655c5f3ce8645716c6abf4e76f20b7b2b452e.

@k8s-bot
Copy link

k8s-bot commented Mar 18, 2016

GCE e2e build/test passed for commit 19f3669f89cd4f0164fcf2e6595084b5c4f69116.

@yujuhong yujuhong assigned yujuhong and unassigned dchen1107 Mar 18, 2016
@k8s-github-robot
Copy link

@yujuhong
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-bot
Copy link

k8s-bot commented Mar 18, 2016

GCE e2e build/test passed for commit 6d6d360a700341d4acacb9f0ecdbc8850a29f1f8.

@k8s-bot
Copy link

k8s-bot commented Mar 19, 2016

GCE e2e build/test passed for commit 89feb6f.

@yujuhong yujuhong added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2016
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Mar 21, 2016

GCE e2e build/test passed for commit 89feb6f.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit 89feb6f.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Mar 22, 2016

GCE e2e build/test passed for commit 89feb6f.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Mar 22, 2016
Merge pull request #23205 from yifan-gu/append_image_tag
566d23e 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 566d23e into kubernetes:master Mar 22, 2016
@yifan-gu yifan-gu deleted the append_image_tag branch March 22, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yujuhong yujuhong

Labels
area/rkt lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yifan-gu @k8s-github-robot @k8s-bot @k8s-teamcity-mesosphere @googlebot @dchen1107 @yujuhong