Remove deep-copy pre-commit hook that no longer exists #23244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fejta
added
the
priority/important-soon
k8s-github-robot
added
the
size/S
|
Labelling this PR as size/S |
|
LGTM |
wojtek-t
added
the
lgtm
|
GCE e2e build/test passed for commit 4fc95c1. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 4fc95c1. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Mar 19, 2016
Auto commit by PR queue bot
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this pull request
Jun 26, 2019
remove a revert on the upstream test infrastructure Origin-commit: d3ae51188b8c78b5f6f17884946d560c5c3cea00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot commit changes because the reference to this deleted code still exists in hooks/pre-commit. It looks like we can just delete it?
#23110 moved deep-copy into run-codegen.sh and #23179 deleted it entirely.
@lavalamp @wojtek-t