Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #24833 upstream release 1.2 #25155

Conversation

roberthbailey
Copy link
Contributor

Cherry pick of #24833 on release-1.2.

Also patch up a log statement to log the service's namespace and name
rather than potentially just logging `kind:"" apiVersion:""`.
@roberthbailey
Copy link
Contributor Author

/cc @a-robinson

@k8s-github-robot k8s-github-robot added this to the v1.2 milestone May 4, 2016
@k8s-github-robot k8s-github-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2016
@a-robinson a-robinson added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2016
@a-robinson a-robinson closed this May 5, 2016
@a-robinson a-robinson reopened this May 5, 2016
@roberthbailey
Copy link
Contributor Author

@k8s-bot test this issue: #25153

@k8s-bot
Copy link

k8s-bot commented May 5, 2016

GCE e2e build/test passed for commit 0bd5395.

@roberthbailey roberthbailey merged commit 5ffeaef into kubernetes:release-1.2 May 5, 2016
@roberthbailey roberthbailey deleted the automated-cherry-pick-of-#24833-upstream-release-1.2 branch May 23, 2016 17:44
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…ry-pick-of-#24833-upstream-release-1.2

Automated cherry pick of kubernetes#24833 upstream release 1.2
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
…ry-pick-of-#24833-upstream-release-1.2

Automated cherry pick of kubernetes#24833 upstream release 1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants