[GarbageCollector] Let the dynamic client take runtime.Object instead of v1.ListOptions #25423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
size/S
caesarxuchao
force-pushed
the
dynamic-listoptions
branch
from
037c296
to
2aa95e2
Compare
test/integration/dynamic_client_test.go:93: cannot use "k8s.io/kubernetes/pkg/api/v1".ListOptions literal (type "k8s.io/kubernetes/pkg/api/v1".ListOptions) as type "k8s.io/kubernetes/pkg/runtime".Object in argument to dynamicClient.Resource(&resource, "k8s.io/kubernetes/test/integration/framework".TestNS).List:
"k8s.io/kubernetes/pkg/api/v1".ListOptions does not implement "k8s.io/kubernetes/pkg/runtime".Object (GetObjectKind method has pointer receiver)
FAIL k8s.io/kubernetes/test/integration [build failed]You can run |
caesarxuchao
force-pushed
the
dynamic-listoptions
branch
from
2aa95e2
to
c7d1112
Compare
|
Thanks. Updated. |
krousey
added
the
lgtm
k8s-github-robot
removed
the
lgtm
lavalamp
added
lgtm
|
GCE e2e build/test passed for commit c7d1112. |
|
Automatic merge from submit-queue |
caesarxuchao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that I can pass whatever version of ListOptions to the List/Watch/DeleteCollection methods.
cc @krousey
This change is