Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a more consistent naming policy for TPRs #29415

Closed
duglin opened this issue Jul 22, 2016 · 4 comments
Closed

Have a more consistent naming policy for TPRs #29415

duglin opened this issue Jul 22, 2016 · 4 comments
Labels
area/custom-resources sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@duglin
Copy link

duglin commented Jul 22, 2016

Right now if I create a third party resource (TPR):

  • I give it a name of org1-type.myorg1.org
  • I create new resources by POSTing to apis/myorg1.org/v1/namespaces/default/org1types
  • with a kind of Org1Type

that's 3 different ways the name is referenced: org1-type, org1types, Org1Type

I would recommend that we not do any name tweaking. Let the user pick the name and then just use that. Using anything else means each client would need to mimic those rules which runs the risk of them getting it wrong. It adds a layer of confusion for no reason.

@duglin
Copy link
Author

duglin commented Jul 22, 2016

/cc @lavalamp

@lavalamp lavalamp added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 22, 2016
@lavalamp
Copy link
Member

Yeah, this is really unfortunate. It's also not trivial to change. :/

@liggitt
Copy link
Member

liggitt commented Feb 13, 2017

the TPR type needs to specify the kind, singular, and plural resource names

@enisoc
Copy link
Member

enisoc commented May 16, 2017

This is addressed in the proposal for moving TPR to beta. The various names are specified explicitly by the user.

@enisoc enisoc closed this as completed May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/custom-resources sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

4 participants