Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @rootfs the assignee for various volumes #31303

Merged
merged 1 commit into from
Sep 5, 2016

Conversation

thockin
Copy link
Member

@thockin thockin commented Aug 23, 2016

This, combined with the '/lgtm' capability of reviewers means you can approve
PRs. @rootfs - I assume you're OK with this?


This change is Reviewable

This, combined with the '/lgtm' capability of reviewers means he can approve
PRs.
@matchstick matchstick added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2016
@matchstick
Copy link
Contributor

👍

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Aug 23, 2016
@thockin thockin added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Aug 23, 2016
@rootfs
Copy link
Contributor

rootfs commented Aug 23, 2016

gift taken :)

@k8s-bot
Copy link

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@thockin
Copy link
Member Author

thockin commented Sep 1, 2016

@k8s-bot test this: github issue #IGNORE

@k8s-bot
Copy link

k8s-bot commented Sep 5, 2016

GCE e2e build/test passed for commit d0a8407.

@goltermann goltermann added this to the v1.4 milestone Sep 5, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Sep 5, 2016

GCE e2e build/test passed for commit d0a8407.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 54b47dc into kubernetes:master Sep 5, 2016
@thockin thockin deleted the volume-owners branch November 2, 2016 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants