Update build docs to include path for scripts. #31398
Conversation
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
6 similar comments
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
k8s-github-robot
added
size/S
| @@ -23,16 +23,16 @@ There is also early support for building Docker "run" containers | |||
|
|
|||
| The following scripts are found in the `build/` directory: | |||
There was a problem hiding this comment.
maybe add a sentence here noting that these scripts must be run from the Kubernetes root directory?
|
ok to test |
ixdy
added
release-note-none
This fix updates the build docs to include the path of `build/` for shell scripts. The reason is that while trying to follow the `build/README.md`, it is not obvious that all the scripts, e.g., `run.sh make`, `shell.sh`, etc. needs to be executed from the root directory (vs. executed from the `build/` directory). In other words, the executation should be: ``` build/run.sh make build/make-clean.sh ... ``` This fix adds `build/` so that it is easy for user to follow the steps.
|
Thanks @ixdy. The pull request has been updated with note added. Please let me know if there are any issues. |
ixdy
added
the
lgtm
|
LGTM |
|
GCE e2e build/test passed for commit e939dd3. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. |
|
Automatic merge from submit-queue |
What this PR does / why we need it:
This fix updates the build docs (
build/README.md) to include the path ofbuild/for shell scripts (likerun.sh,shell.sh).The reason is that while trying to follow the
build/README.mdto build the kubernetes, it is not obvious that all the scripts, e.g.,run.sh make,shell.sh, etc. needs to be executed from the root directory (vs. executed from thebuild/directory).In other words, the executation should be:
This fix adds
build/so that it is easy for user to follow the steps.Which issue this PR fixes (optional, in
fixes #<issue number>(, #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note:
This change is