-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-run godep license #38388
re-run godep license #38388
Conversation
Looks like #37305 changed it. At least the update makes more sense now. |
Thanks @deads2k. Merging to fix SQ. |
LGTM 👍 |
Wait, shouldn't we revert LICENSE file in the repo root instead? Right now we have a license template, not actual license in Godeps/LICENSES |
I will not even pretend to know. It chains to this issue: kubernetes/kubernetes-template-project#3 . I just want a working queue, so any path to getting there works for me. |
@deads2k I agree, I will make another PR to fix the issue properly |
The license in the root is an actual license and is not a license template. Kubernetes is licensed under the license in the root. The license contains an appendix that explains how you too can license your code under the same license. The appendix contains a line:
That people often incorrectly change to
But that line should remain in template form since it's in the instructional section of how to apply the Apache v2 license. cc @philips |
@mikedanese OK, thanks for the explanation! |
re-run
update-godep-licenses
to see what happens. The result looks weird.