Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create selector and namespaces in a loop where possible #38693

Merged
merged 1 commit into from Dec 16, 2016
Merged

Do not create selector and namespaces in a loop where possible #38693

merged 1 commit into from Dec 16, 2016

Conversation

dshulyak
Copy link
Contributor

cherry-pick from #37691

Not automated cause i had to change versions of api objects

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 13, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Dec 13, 2016
@dshulyak
Do not create selector and namespaces in a loop where possible
d14fc1e 
Change-Id: Ib8e62df92a3ea6b8ee6b90cb0b73af71332481d7
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 0c8ce0b52383c22deb4bc7fc0ab0ebd4c9814767. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 0c8ce0b52383c22deb4bc7fc0ab0ebd4c9814767. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 0c8ce0b52383c22deb4bc7fc0ab0ebd4c9814767. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 0c8ce0b52383c22deb4bc7fc0ab0ebd4c9814767. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 0c8ce0b52383c22deb4bc7fc0ab0ebd4c9814767. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 0c8ce0b52383c22deb4bc7fc0ab0ebd4c9814767. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 0c8ce0b52383c22deb4bc7fc0ab0ebd4c9814767. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit 0c8ce0b52383c22deb4bc7fc0ab0ebd4c9814767. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 0c8ce0b52383c22deb4bc7fc0ab0ebd4c9814767. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@dshulyak
Copy link
Contributor Author

@wojtek-t Hi, please take a look at this cherry-pick when you will have time. It would be awesome to land it before 1.5.2 is released.

@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. cherrypick-candidate and removed release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Dec 15, 2016
@wojtek-t wojtek-t self-requested a review December 15, 2016 10:29
@wojtek-t wojtek-t added this to the v1.5 milestone Dec 15, 2016
@wojtek-t
Copy link
Member

/lgtm

@saad-ali needs to also approve cherrypick

@k8s-ci-robot
Copy link
Contributor

@wojtek-t: you can't LGTM a PR unless you are assigned as a reviewer.

In response to this comment:

/lgtm

@saad-ali needs to also approve cherrypick

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 15, 2016
@saad-ali saad-ali added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 15, 2016
@saad-ali saad-ali removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 15, 2016
@saad-ali
Copy link
Member

Ok to merge to 1.5 once LGTM'd by assignee or reviewer.

@wojtek-t wojtek-t self-assigned this Dec 16, 2016
@wojtek-t wojtek-t added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 16, 2016
@wojtek-t
Copy link
Member

LGTM - thanks @saad-ali !

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit d14fc1e. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 54fc6bd into kubernetes:release-1.5 Dec 16, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@davidopp davidopp

@wojtek-t wojtek-t

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@dshulyak @k8s-reviewable @k8s-ci-robot @wojtek-t @saad-ali @k8s-github-robot @k8s-cherrypick-bot @davidopp