bazel: fix some unit tests #38841
Merged
bazel: fix some unit tests #38841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
This change is |
ixdy
reviewed
Dec 15, 2016
| tags = ["automanaged"], | ||
| tags = [ | ||
| "automanaged", | ||
| "skip", |
There was a problem hiding this comment.
This is basically an integration test that shells out to kubeadm.
There was a problem hiding this comment.
can you leave a comment here noting that?
There was a problem hiding this comment.
Added an integration tag.
| @@ -26,6 +26,9 @@ go_library( | |||
| go_test( | |||
| name = "go_default_xtest", | |||
| srcs = ["policy_test.go"], | |||
| data = glob([ | |||
| "testdata/*", | |||
There was a problem hiding this comment.
should we remove the automanaged tag?
There was a problem hiding this comment.
automanged doesn't touch data field. This is fine.
k8s-github-robot
added
size/XS
mikedanese
force-pushed
the
fix-tests
branch
from
f1f7328
to
0f8ed87
Compare
k8s-github-robot
added
size/M
mikedanese
force-pushed
the
fix-tests
branch
from
0f8ed87
to
dd47477
Compare
mikedanese
added
release-note-none
mikedanese
force-pushed
the
fix-tests
branch
from
dd47477
to
8fdec87
Compare
|
/lgtm @k8s-bot bazel test this |
k8s-ci-robot
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.